QCAD

QCAD - 2D CAD System.

Click here for a documentation of the DokuWiki formatting syntax that can be used in reports

Please search for existing tasks (also closed ones) before opening a new task.

Please make sure that you are using the latest Version of QCAD before posting a bug (menu Help - Check for Updates)

Tasklist

FS#324 - SVG export depends on GUI

Attached to Project: QCAD
Opened by Peter (hungerburg) - Thursday, 20 October 2011, 12:19 GMT
Last edited by Andrew (andrew) - Thursday, 20 October 2011, 14:07 GMT
Task Type Feature Request
Category ECMAScript
Status Closed
Assigned To Andrew (andrew)
Operating System All
Severity Low
Priority Normal
Reported Version 3 Beta 3
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

SvgExporter.js uses PrintPreview to parse the scale string, and therefore depends on the qt GUI part. That should not make maintenance harder to call RMath directly there? Results seem to match from a first look.

--- SvgExporter.js~	2011-10-20 14:11:45.527589416 +0200
+++ SvgExporter.js	2011-10-20 14:12:46.277502814 +0200
@@ -1,6 +1,5 @@
 include("scripts/library.js");
 include("scripts/date.js");
-include("scripts/File/PrintPreview/Print.js");
 
 /**
  * File exporter implementation for the SVG format.
@@ -116,7 +115,7 @@
     this.svgUnitAbbr = ret[1];
 
     // scale
-    this.scale = Print.parseScale(this.scaleStr);
+    this.scale = RMath.parseScale(this.scaleStr);
 
     var bb = this.doc.getBoundingBox();
     var size = bb.getSize();
This task depends upon

Closed by  Andrew (andrew)
Thursday, 20 October 2011, 14:07 GMT
Reason for closing:  Fixed
Comment by Andrew (andrew) - Thursday, 20 October 2011, 14:07 GMT

You're right. That dependency was ugly and unnecessary since parseScale moved to RMath, thanks.

Loading...