close a polygon [SOLVED]

[arun]

Hi,
I am running this test script where I have this polygon entity which is not closed.

Code: Select all

var doc = getDocument();
var entityIds = doc.queryAllEntities(); //58,59
var p1 = doc.queryEntity(59)
p1.isClosed() //false
p1.countVertices() //5
p1.getVertexAt(0) //"RVector(71505.600000, 5084.500000, 0.000000, 1)"
p1.getVertexAt(4) //"RVector(71505.600000, 5084.500000, 0.000000, 1)"

How do I close this polyline?

Thanks,
Arun

[andrew]

There are two types of "closed" polylines in CAD / DXF:
Logically closed: The "closed" flag is set, the polyline is defined as being a closed polyline.
Geometrically closed: The polyline start point is identical with its end point.

isClosed returns true if the polyline is logically closed.
isGeometricallyClosed returns true if the polyline is geometrically closed

Logically closed polylines are always also geometrically closed.

You can also call autoClose on your polyline to logically close it if start and end points match.

[CVH]

arun,
What you have is a geometrically closed polyline entity ... The end vertex is equal to the start vertex.
But it is considered not logically closed.
p1.isClosed() ... p1.setClosed() are about the logical closed nature.
There is also p1.isGeometricallyClosed()

Have a look here:
https://qcad.org/doc/qcad/3.0/developer ... cb6735889f
or
https://qcad.org/doc/qcad/3.0/developer ... 87c7cfedeb

When you set or convert the queried polyline to a closed one you need to return that to the document with an operation.

Regards,
CVH

[arun]

Thanks CVH, Andrew

CVH

When you set or convert the queried polyline to a closed one you need to return that to the document with an operation.

Didnt understand on this point.
How do I return the polyline to the document. I also observed that the changes to the polyline is not getting updated in the document.
Confused on how this is done.

Arun

[arun]

Got it.
This particular post from CVH helped in understanding https://www.qcad.org/rsforum/viewtopic. ... 28&p=35408

This is my code for reference

Code: Select all

var doc = getDocument();

var layerName = getText();
var entitiesIds = doc.queryLayerEntities(doc.getLayerId(layerName));

var fileName = doc.getFileName()

var openP = []

for (var i=0; i<entitiesIds.length; i++) {
    var entityId = entitiesIds[i];
    var entity = doc.queryEntity(entityId);
    if (!entity.isClosed()) {
        openP.push(entityId);
    }
}

var di = getDocumentInterface();
var op = new RModifyObjectsOperation();
for (var j=0; j<openP.length; j++) {
    var polyL = doc.queryEntity(openP[j]);
    polyL.autoClose();
    op.addObject(polyL, false);
}
di.applyOperation(op);
di.exportFile(fileName);