QCAD Bugtracker

Example: Start with an empty CAM tool list. Add one tool with tool name “1” as suggested by the dialog (the other values not relevant).
Click the ‘Add tool’-button again. The dialog suggests “2” as tool number. Change the tool number to “1”. Below the input fields, there appears an error message “Tool already exists”.
But it is still possible to click the OK button. The previously set values are overwritten without notice. Expected behaviour is that the OK button is disabled as long as the error (dublicate tool) occurs.

Suggested fix: In file CamToolDialog.js in the function CamToolDialog.prototype.validate (lines 106 and following):
Change

valid = valid && this.validateToolName(msgs, false);
valid = valid && ResourceDialog.prototype.validate.call(this, valid, msgs);

to

valid = valid & this.validateToolName(msgs, false);
valid = valid & ResourceDialog.prototype.validate.call(this, valid, msgs);

Explanation: && is logical AND. If the first operand is false, the second operand is not evaluated...
In this case, the bitwise AND must be used.

Workaround until the bug is fixed:
Overwrite the CamToolDialog.prototype.validate in your postprocessor script with the fix given above.

Example: Click on the ‘Add tool’-button to open the CAMToolDialog. Initially, the values for tool diameter, speeds and feeds are empty. But the OK button is enabled.
By clicking OK, the invalid / empty values are taken for the new tool without error.

Suggested fix: The validation function should be called once after the dialog has been created / shown. This should show the according error messages and disable the OK button.

Workaround until the bug is fixed:
Overwrite the function CamToolDialog.prototype.afterShow in your postprocessor script and call the according validate function:

CamToolDialog.prototype.afterShow = function() {
	CamToolDialog.prototype.validate.call(this);
	return true;
}

Please let me know if you need more details.
Regards,
Deejay