Download QCAD

← All bug reports

FS#2498Adjust tooltip shortcut color and command line message color when dark mode changes

Type
Feature Request
Status
Closed
Resolution
Implemented
Category
QCAD (main)
Severity
Low
Priority
Low
Reported version
3.28.2
Operating system
macOS (All)
Reported
2023-10-28 by lightbulbjim
Closed
2024-04-11 by andrew
Votes
1

On macOS 14.1 and QCAD 3.28.2, the state of the OS (light or dark theme) affects some of the QCAD colour palette for the life of the session. So far I've noticed the problem with the keyboard shortcuts in tooltips and text in the command line output, but there may be other instances of the problem.

To reproduce:

1. Set the OS to light mode.

2. Start QCAD. Note the keyboard shortcuts in the tooltips are optimised for a light palette.

3. With QCAD still running, switch the OS to dark mode.

4. Note that while most of the QCAD interface switches to a dark mode palette, the keyboard shortcuts in the tooltips do not.

A similar behaviour is observed when starting from dark mode and switching to light mode.

I hope that makes sense. See attached screenshots for examples.

Comments (5)

CVH 2023-10-28

Hi,
Can it be that there is no text in the Command Line to compare in Command line.png?

What I think that happens is that somethings are formatted at script level.
And that that depends on parameters sourced on startup.

A remark earlier by Andrew is that not everything can be formatted based on CSS and thus on themes. I think that in those cases things are hardcoded and that QCAD is not aware of OS theme change after startup.

Question remains if QCAD should monitor OS themes changes at all time ;-)

Regards,
CVH

lightbulbjim 2023-10-28

Can it be that there is no text in the Command Line to compare in Command line.png?

Apologies, I should have clarified. In the command line example I was referring to the blue "Command: save" text. I triggered the save command before and after switching the theme.

A remark earlier by Andrew is that not everything can be formatted based on CSS and thus on themes. I think that in those cases things are hardcoded and that QCAD is not aware of OS theme change after startup.

Generally with Cocoa apps it's possible to use the system* versions of NSColor for things like this, and no adjustments are needed when switching themes (they are not hardcoded colour values). I'm not sure how much of that API is exposed through QT.

See the docs here: https://developer.apple.com/documentation/appkit/nscolor/standard_colors

CVH 2023-10-29

Remark that QCAD is designed to be portable.
It is not intended solely for Apple based OS systems.
Of course it should be possible to do this platform based.

Still, I think it's a matter of priorities.

I only count 13 Adaptable System Colors and that might be too limited.

Regards,
CVH

lightbulbjim 2023-10-29

Understood, however the tooltips and command line history are pretty important UI elements. If a way could be found to make them work better then that would be desirable. But I understand that there are many competing priorities.

I'll leave it in your capable hands.

CVH 2023-10-29

Indeed, let's leave it to the developer to decide where the priorities lie.
Over to Andrew.

Regards,
CVH